Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature flag Papercups #2799

Merged
merged 5 commits into from Dec 16, 2020
Merged

Feature flag Papercups #2799

merged 5 commits into from Dec 16, 2020

Conversation

paolodamico
Copy link
Contributor

Changes

Puts Papercups behind the papercups-enabled feature flag.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@timgl timgl temporarily deployed to posthog-papercups-featu-ut5hif December 16, 2020 17:49 Inactive
@Twixes Twixes requested a deployment to posthog-papercups-featu-ut5hif December 16, 2020 20:37 Abandoned
@Twixes Twixes temporarily deployed to posthog-papercups-featu-ut5hif December 16, 2020 20:39 Inactive
Twixes
Twixes approved these changes Dec 16, 2020
View reviewed changes
Copy link
Collaborator

@Twixes Twixes left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely cool idea. This actually allows us to use Papercups' React component @papercups-io/chat-widget, which I refactored this to. Quite elegant.

@Twixes
Copy link
Collaborator

Twixes commented Dec 16, 2020

Also added more detailed info on the inquiring user with metadata:

metadata

@Twixes Twixes merged commit febaed2 into master Dec 16, 2020
@Twixes Twixes deleted the papercups-feature-flag branch December 16, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Twixes Twixes Twixes approved these changes

@yakkomajuri yakkomajuri Awaiting requested review from yakkomajuri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paolodamico @Twixes @timgl