Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore plugins optional deps #2801

Merged
merged 2 commits into from Dec 16, 2020
Merged

Ignore plugins optional deps #2801

merged 2 commits into from Dec 16, 2020

Conversation

mariusandra
Copy link
Collaborator

Changes

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@timgl timgl temporarily deployed to posthog-ignore-plugins--svgizv December 16, 2020 22:21 Inactive
Copy link
Collaborator

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the simplest solution, though I don't know where to verify that it actually worked. As in, did this unix-dgram problem appear in CI logs before?

@mariusandra
Copy link
Collaborator Author

This definitely makes the install faster and removes something we don't need.

I started seeing the errors with posthog-plugin-server 0.5.1 that includes hot-shots. The build-essential package was not installed in many environments when yarn install ran, causing it to fail. Since this is just an optional dependency, we never noticed. Adding rdkafka however made the problem visible... and it's now fixed in most places, except for AWS ECS.

So I'm actually not sure if this is even needed. It will make somethings just a bit faster though.

Copy link
Collaborator

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can try this out.

@Twixes Twixes merged commit c191fef into master Dec 16, 2020
@Twixes Twixes deleted the ignore-plugins-optional-deps branch December 16, 2020 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants