Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Plugin Server #2816

Merged
merged 2 commits into from Dec 21, 2020
Merged

Upgrade Plugin Server #2816

merged 2 commits into from Dec 21, 2020

Conversation

mariusandra
Copy link
Collaborator

Changes

  • Upgrade Plugin Server to 0.6.1
  • Update the key to enable KAFKA for it

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@timgl timgl temporarily deployed to posthog-plugin-server-k-zhekd3 December 18, 2020 09:36 Inactive
Copy link
Collaborator

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to add the Kafka encryption env cars to KEYS.

@mariusandra
Copy link
Collaborator Author

If they are passed as ENV variables, the plugin server can pick them up automatically, no need to pipe through the shell script.

They are currently not in settings and used directly (os.environ["KAFKA_CLIENT_CERT_KEY_B64"]) in django, so I thought to do that here instead of making new lines in settings.py

Copy link
Collaborator

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah,yeah, of course.

@mariusandra mariusandra merged commit 39239c2 into master Dec 21, 2020
@mariusandra mariusandra deleted the plugin-server-kafka branch December 21, 2020 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants