Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing paths viz condition #2858

Merged
merged 1 commit into from Jan 6, 2021
Merged

Add missing paths viz condition #2858

merged 1 commit into from Jan 6, 2021

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Jan 5, 2021

Changes

Fixes dashboard path item not appearing

Please describe.

  • after filter cleanup, we missed the insight type condition for paths

If this affects the frontend, include screenshots.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@EDsCODE EDsCODE requested a review from timgl January 5, 2021 20:58
@timgl timgl temporarily deployed to posthog-paths-viz-condi-abiqju January 5, 2021 21:00 Inactive
@EDsCODE EDsCODE mentioned this pull request Jan 5, 2021
Merged
4 tasks
@EDsCODE EDsCODE merged commit 8402bc3 into master Jan 6, 2021
@EDsCODE EDsCODE deleted the paths-viz-condition branch January 6, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timgl timgl Awaiting requested review from timgl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EDsCODE @timgl