Adds backend instrumentation to actions & cohorts #2887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macobo
reviewed
Jan 8, 2021
macobo
reviewed
Jan 8, 2021
| @@ -61,6 +61,24 @@ class Cohort(models.Model): | |||
|
|
|||
| objects = CohortManager() | |||
|
|
|||
| def get_analytics_metadata(self): | |||
| action_groups_count: int = 0 | |||
There was a problem hiding this comment.
Nit: imo cleaner:
action_groups_count = len(1 for group in self.groups if group.has("action_id"))
There was a problem hiding this comment.
Agreed it's cleaner, but then we're doing 2n instead of n loop sequences because we would need one for each action & properties. I did optimize the code a bit based on this suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #1575.
action created&action updatedserver-side events with a bunch of metadata.cohort created&cohort updatedevents.Particularly worth noting that there are no
{action|cohort} deletedevents because we currently only support soft-deleting these, which woudl trigger a{action|cohort updatedevent with adeleted = Trueattribute.Checklist