Refactor properties_to_Q to not be tied to Filter objects #2890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we can pass other kinds of property lists in there. 1) This is needed for session filters (due to different kinds of property filters) 2) It makes the postgres codebase more consistent with ee which does a similar thing.
macobo
force-pushed
the
properties_to_Q
branch
from
42550f9
to
ca6fcbd
Compare
macobo
force-pushed
the
properties_to_Q
branch
from
eae6087
to
a8808b3
Compare
timgl
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we can pass other kinds of property lists in there.
property filters)
similar thing.
No behavioral changes - pure code change. Splitting this out to keep main PR (more) managable + to run CI.
Checklist