Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix REST hook firing #2894

Merged
merged 22 commits into from
Jan 12, 2021
Merged

Fix REST hook firing #2894

merged 22 commits into from
Jan 12, 2021

Conversation

Twixes
Copy link
Collaborator

@Twixes Twixes commented Jan 8, 2021 •
edited
Loading

Changes

Fixes REST hook firing (Zapier triggers). Due to an oversight they were only fired in EE if the project had a webhook set, but that's entirely separate from Zapier.
This also fixes an issue where organization-less teams were allowed to be created, which was revealed by tests.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User

@Twixes Twixes changed the title Fix rest hook fire Fix REST hook firing Jan 8, 2021
@timgl timgl temporarily deployed to posthog-fix-rest-hook-f-4quw9a January 8, 2021 11:24 Inactive
@Twixes Twixes marked this pull request as draft January 8, 2021 11:31
@Twixes Twixes temporarily deployed to posthog-fix-rest-hook-f-4quw9a January 8, 2021 14:40 Inactive
@Twixes Twixes marked this pull request as ready for review January 8, 2021 15:42
@Twixes Twixes temporarily deployed to posthog-fix-rest-hook-f-4quw9a January 11, 2021 10:46 Inactive
@Twixes Twixes temporarily deployed to posthog-fix-rest-hook-f-4quw9a January 11, 2021 11:03 Inactive
@Twixes Twixes temporarily deployed to posthog-fix-rest-hook-f-4quw9a January 11, 2021 11:24 Inactive
@Twixes Twixes temporarily deployed to posthog-fix-rest-hook-f-4quw9a January 11, 2021 11:27 Inactive
@Twixes Twixes temporarily deployed to posthog-fix-rest-hook-f-4quw9a January 11, 2021 11:37 Inactive
@Twixes Twixes temporarily deployed to posthog-fix-rest-hook-f-4quw9a January 11, 2021 11:49 Inactive
@Twixes Twixes temporarily deployed to posthog-fix-rest-hook-f-4quw9a January 11, 2021 11:58 Inactive
@Twixes Twixes temporarily deployed to posthog-fix-rest-hook-f-4quw9a January 11, 2021 12:16 Inactive
@Twixes Twixes temporarily deployed to posthog-fix-rest-hook-f-4quw9a January 11, 2021 12:23 Inactive
@Twixes Twixes temporarily deployed to posthog-fix-rest-hook-f-4quw9a January 11, 2021 12:29 Inactive
@Twixes Twixes temporarily deployed to posthog-fix-rest-hook-f-4quw9a January 11, 2021 12:36 Inactive
@Twixes Twixes requested a review from macobo January 11, 2021 13:29
@Twixes Twixes temporarily deployed to posthog-fix-rest-hook-f-4quw9a January 11, 2021 14:01 Inactive
@Twixes Twixes temporarily deployed to posthog-fix-rest-hook-f-4quw9a January 11, 2021 14:04 Inactive
@Twixes Twixes temporarily deployed to posthog-fix-rest-hook-f-4quw9a January 11, 2021 14:14 Inactive
@Twixes Twixes temporarily deployed to posthog-fix-rest-hook-f-4quw9a January 11, 2021 14:22 Inactive
mariusandra
mariusandra approved these changes Jan 12, 2021
View reviewed changes
Copy link
Collaborator

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, though it's quite hard to get into it and test everything thoroughly. I trust you know what you're doing here, so LGTM.

@Twixes Twixes merged commit 5d5ede1 into master Jan 12, 2021
@Twixes Twixes deleted the fix-rest-hook-fire branch January 12, 2021 12:09
@Twixes Twixes removed the request for review from macobo January 12, 2021 12:09
@macobo macobo mentioned this pull request Jan 28, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusandra mariusandra mariusandra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Twixes @mariusandra @timgl