Refactor & extend backend user identify #2937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with posthog-production
macobo
reviewed
Jan 14, 2021
macobo
reviewed
Jan 14, 2021
|
Merging now as cloud tests are fixed on https://github.com/PostHog/posthog-production/pull/61 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Previously we had the
$identifylogic for the backend all over the place. This PR refactors the logic so that:a) it's kept in a single place.
b) it's called only in one place.
c) it's called asynchronously every time the user hits
/api/user/. This was motivated because a ton of users are outdated and make it impossible to work on certain analyses.The only exception is that we kept a identify call that sets the
is_first_user&is_organization_first_useronce.The PR also adds more metadata to the request.
Checklist