Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Quite often, /decide hasn't loaded yet by the time we've sent the first
$pageview
event. This means the data on feature flags looks wrong. See below pie chart. This is a feature flag that is set to 50% of users, so clearly we are losing quite a bit of data.We also don't want to have $pageview events waiting for /decide, as that'll cause us to miss pageview events.
This PR automatically adds those missing feature flags to the event.
Checklist