Support multiple action filters in sessions #2946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Session will now contain "action_filter_times" key which lists when each action filter occurred for the first time within the session. This will be used to highlight rows/show special values in sessions player.
macobo
force-pushed
the
postgres-support-action-filters
branch
from
c7e0a68
to
5cd7191
Compare
timgl
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2934
After this it's possible to filter by multiple action filters in both clickhouse and cloud.
We return timestamps for when user performed the action as well, this can be used
to highlight rows as below and show shortcuts in session recording.
Checklist