Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only cache new items for 1 day #2949

Merged
merged 3 commits into from Jan 14, 2021
Merged

Only cache new items for 1 day #2949

merged 3 commits into from Jan 14, 2021

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Jan 14, 2021

Changes

Please describe.

  • currently caching everything for a week. changing this to only cache new items for 60 seconds and only caching for a week if the item is on dashboard
    If this affects the frontend, include screenshots.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@EDsCODE EDsCODE requested a review from timgl January 14, 2021 15:32
@timgl timgl temporarily deployed to posthog-reduce-ttl-temp-ir4cdl January 14, 2021 15:36 Inactive
@Twixes
Copy link
Collaborator

Twixes commented Jan 14, 2021

How about caching for a day on dashboards?

@timgl
Copy link
Collaborator

timgl commented Jan 14, 2021

Yep agree, we've managed to have the app not look broken (despite clickhouse being unusable) because of longer caching.

@EDsCODE EDsCODE temporarily deployed to posthog-reduce-ttl-temp-ir4cdl January 14, 2021 18:23 Inactive
@EDsCODE
Copy link
Member Author

EDsCODE commented Jan 14, 2021

good point. done!

@timgl timgl changed the title Only cache new items for 60 seconds Only cache new items for 1 day Jan 14, 2021
@timgl timgl merged commit 8857ca3 into master Jan 14, 2021
@timgl timgl deleted the reduce-ttl-temp-queries branch January 14, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timgl timgl Awaiting requested review from timgl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EDsCODE @Twixes @timgl