Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support plugins installed from GitLab #2970

Merged
merged 4 commits into from Jan 19, 2021
Merged

Support plugins installed from GitLab #2970

merged 4 commits into from Jan 19, 2021

Conversation

mariusandra
Copy link
Collaborator

Changes

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@timgl timgl temporarily deployed to posthog-gitlab-plugins-jevjqux January 18, 2021 13:20 Inactive
Twixes
Twixes reviewed Jan 18, 2021
View reviewed changes
posthog/plugins/utils.py Outdated Show resolved Hide resolved
@Twixes Twixes temporarily deployed to posthog-gitlab-plugins-jevjqux January 18, 2021 15:37 Inactive
Twixes
Twixes approved these changes Jan 18, 2021
View reviewed changes
Copy link
Collaborator

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Twixes Twixes changed the title Support gitlab plugins Support plugins installed from GitLab Jan 18, 2021
@Twixes Twixes temporarily deployed to posthog-gitlab-plugins-jevjqux January 19, 2021 00:17 Inactive
@Twixes
Copy link
Collaborator

Twixes commented Jan 19, 2021 •
edited

Mypy complains because property tag is optional on parse_gitlab_url results, while being obligatory elsewhere – could you resolve the typechecking error and see that this is optionality is handled wherever needed?

@mariusandra mariusandra temporarily deployed to posthog-gitlab-plugins-jevjqux January 19, 2021 09:42 Inactive
@mariusandra
Copy link
Collaborator Author

mypy is cursed... but got it to work in the end. Cypress test failing, so merging.

@mariusandra mariusandra merged commit 45811dd into master Jan 19, 2021
@mariusandra mariusandra deleted the gitlab-plugins branch January 19, 2021 10:07
@FUSAKLA
Copy link
Contributor

FUSAKLA commented Jan 19, 2021

Great! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Twixes Twixes Twixes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitLab Plugins
4 participants
@mariusandra @Twixes @FUSAKLA @timgl