Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Once #2972

Merged
merged 4 commits into from
Jan 18, 2021
Merged

Set Once #2972

merged 4 commits into from
Jan 18, 2021

Conversation

mariusandra
Copy link
Collaborator

@mariusandra mariusandra commented Jan 18, 2021 •
edited by paolodamico
Loading

Changes

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@timgl timgl temporarily deployed to posthog-set-once-4ypdlsvz4jwue January 18, 2021 13:54 Inactive
@mariusandra mariusandra marked this pull request as draft January 18, 2021 14:01
@mariusandra mariusandra temporarily deployed to posthog-set-once-4ypdlsvz4jwue January 18, 2021 14:08 Inactive
@mariusandra
Copy link
Collaborator Author

Seems to work now! Ready for review.

2021-01-18 15 09 37

@Twixes this is something that should be added to the JS ingestion 😊

@mariusandra mariusandra marked this pull request as ready for review January 18, 2021 14:14
@timgl timgl temporarily deployed to posthog-set-once-4ypdlsvz4jwue January 18, 2021 14:50 Inactive
paolodamico
paolodamico approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@paolodamico paolodamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just added some comments to clarify expected behavior for future reference

@paolodamico paolodamico merged commit 8d65088 into master Jan 18, 2021
@paolodamico paolodamico deleted the set-once branch January 18, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paolodamico paolodamico paolodamico approved these changes

@timgl timgl Awaiting requested review from timgl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support $set_once people.set_once doesn't seem to be working
3 participants
@mariusandra @paolodamico @timgl