Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add try statement for deleting persons incase the table is distributed #3042

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Add try statement for deleting persons incase the table is distributed #3042

merged 1 commit into from
Jan 21, 2021

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Jan 21, 2021

Changes

Please describe.

  • can't delete person on cloud because we have distributed tables now
  • just pass if it doesn't work

If this affects the frontend, include screenshots.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@timgl timgl temporarily deployed to posthog-delete-event-tr-umgtzc January 21, 2021 20:22 Inactive
fuziontech
fuziontech approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@fuziontech fuziontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@EDsCODE EDsCODE merged commit cba416b into master Jan 21, 2021
@EDsCODE EDsCODE deleted the delete-event-try branch January 21, 2021 20:30
@macobo macobo mentioned this pull request Jul 5, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuziontech fuziontech fuziontech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EDsCODE @fuziontech @timgl