Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing logic for action days in cohort calculating #3056

Merged
merged 3 commits into from
Jan 26, 2021
Merged

Add missing logic for action days in cohort calculating #3056

merged 3 commits into from
Jan 26, 2021

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Jan 22, 2021 •
edited
Loading

Changes

Please describe.

  • fixes the cohort time filter not doing anything
    If this affects the frontend, include screenshots.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@timgl timgl temporarily deployed to posthog-3041-add-cohort-llnfjo January 22, 2021 15:04 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-3041-add-cohort-llnfjo January 22, 2021 17:58 Inactive
@EDsCODE EDsCODE marked this pull request as ready for review January 22, 2021 18:02
@EDsCODE EDsCODE temporarily deployed to posthog-3041-add-cohort-llnfjo January 22, 2021 18:02 Inactive
@EDsCODE EDsCODE requested a review from timgl January 25, 2021 14:57
@timgl timgl merged commit 2fef103 into master Jan 26, 2021
@timgl timgl deleted the 3041-add-cohort-action-days-logic branch January 26, 2021 12:26
This was referenced Feb 3, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timgl timgl Awaiting requested review from timgl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EDsCODE @timgl