-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin upgrades #3057
Plugin upgrades #3057
Conversation
I think it'd be cool to just run this whenever the page loads rather than on the button click. Much higher chance people will see & actually update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
100% should run automatically (though not more often than x amount of time).
The plugins will now check for updates when the page opens. More specifically, I set it to cache the "latest_tag" for each plugin for 30min (with postgres) and it'll only check on page load if the status isn't stale. Clicking on the "check for updates" button checks all plugins. Currently clicking "check for all updates" tends to exhaust the github api limit quite quickly. This will be fixed when #3070 lands. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
Changes
Adds a button "Check for upgrades" that checks each plugin if it's the latest github commit / gitlab commit / npm version. If not, you can click to update.
![2021-01-22 16 25 58](https://user-images.githubusercontent.com/53387/105510274-bd11a280-5cce-11eb-9206-ca03de1895e0.gif)
If there's an error connecting to the backend (e.g. github api key limit exceeded, happens often), we show an error:
![image](https://user-images.githubusercontent.com/53387/105510343-d286cc80-5cce-11eb-8459-6b010333e993.png)
If a plugin is enabled, we update it, and afterwards there's a new required field, we directly open the config editor:
![2021-01-22 16 30 34](https://user-images.githubusercontent.com/53387/105510732-4d4fe780-5ccf-11eb-8481-c27d412cb687.gif)
Checklist