Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable PLUGIN_SERVER_INGESTION #3107

Merged
merged 17 commits into from
Feb 4, 2021
Merged

Enable PLUGIN_SERVER_INGESTION #3107

merged 17 commits into from
Feb 4, 2021

Conversation

Twixes
Copy link
Collaborator

@Twixes Twixes commented Jan 27, 2021

Changes

This will move ingestion over to the plugin server, for organizations being part of the limited rollout of plugins on Cloud only (currently two: PostHog and Kea). PLUGINS_CLOUD_WHITELISTED_ORG_IDS will be removed in the next step of rollout, moving over ingestion for everyone.
Needs new plugin server major version.

@timgl timgl temporarily deployed to posthog-hand-off-ingest-sdvjal January 27, 2021 15:54 Inactive
@Twixes Twixes temporarily deployed to posthog-hand-off-ingest-sdvjal January 27, 2021 15:57 Inactive
@Twixes Twixes temporarily deployed to posthog-hand-off-ingest-sdvjal January 28, 2021 12:11 Inactive
@Twixes Twixes temporarily deployed to posthog-hand-off-ingest-sdvjal January 28, 2021 12:38 Inactive
@Twixes Twixes temporarily deployed to posthog-hand-off-ingest-sdvjal February 1, 2021 10:58 Inactive
@Twixes Twixes changed the title Enable PLUGIN_SERVER_INGESTION_HANDOFF Enable PLUGIN_SERVER_INGESTION Feb 1, 2021
@mariusandra mariusandra temporarily deployed to posthog-hand-off-ingest-sdvjal February 3, 2021 22:28 Inactive
@mariusandra mariusandra temporarily deployed to posthog-hand-off-ingest-sdvjal February 3, 2021 22:29 Inactive
@mariusandra mariusandra temporarily deployed to posthog-hand-off-ingest-sdvjal February 3, 2021 22:32 Inactive
@mariusandra mariusandra marked this pull request as ready for review February 3, 2021 22:33
Copy link
Member

@fuziontech fuziontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want to actually enable this in prod? You'll want to update https://github.com/PostHog/posthog/blob/master/task-definition.web.json with the env var you want to flip the switch.

Otherwise this looks good to go! Just one naming suggestion, but no big deal.

posthog/api/capture.py Outdated Show resolved Hide resolved
@mariusandra mariusandra temporarily deployed to posthog-hand-off-ingest-sdvjal February 4, 2021 07:47 Inactive
Copy link
Collaborator Author

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

task-definition.web.json Outdated Show resolved Hide resolved
Comment on lines 105 to 108
{
"name": "PLUGIN_SERVER_INGESTION",
"value": "false"
},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This disables plugin server ingestion though, and this PR is literally "Enable PLUGIN_SERVER_INGSTION" 🤔

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah... :D. To be fair, I'd like to just enable this without the ingestion to make sure the plugin server is able to talk with clickhouse (and we don't get an event lag), before turning it on.

@mariusandra mariusandra temporarily deployed to posthog-hand-off-ingest-sdvjal February 4, 2021 10:43 Inactive
@mariusandra mariusandra temporarily deployed to posthog-hand-off-ingest-sdvjal February 4, 2021 10:56 Inactive
@mariusandra mariusandra temporarily deployed to posthog-hand-off-ingest-sdvjal February 4, 2021 11:21 Inactive
@mariusandra mariusandra temporarily deployed to posthog-hand-off-ingest-sdvjal February 4, 2021 14:02 Inactive
@mariusandra mariusandra merged commit 1f31451 into master Feb 4, 2021
@mariusandra mariusandra deleted the hand-off-ingestion branch February 4, 2021 15:17
@mariusandra
Copy link
Collaborator

Putting this live! Ingestion will still be disabled (PLUGIN_SERVER_INGESTION is set to false for now), but this lets us see if all the other wires hook up or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants