-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable PLUGIN_SERVER_INGESTION #3107
Conversation
…RVER_INGESTION_HANDOFF
fa7e2dd
to
587e7cd
Compare
…out and events in
…rver can talk to kafka & clickhouse before sending real events to it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you want to actually enable this in prod? You'll want to update https://github.com/PostHog/posthog/blob/master/task-definition.web.json with the env var you want to flip the switch.
Otherwise this looks good to go! Just one naming suggestion, but no big deal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
task-definition.web.json
Outdated
{ | ||
"name": "PLUGIN_SERVER_INGESTION", | ||
"value": "false" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This disables plugin server ingestion though, and this PR is literally "Enable PLUGIN_SERVER_INGSTION" 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah... :D. To be fair, I'd like to just enable this without the ingestion to make sure the plugin server is able to talk with clickhouse (and we don't get an event lag), before turning it on.
Putting this live! Ingestion will still be disabled ( |
Changes
This will move ingestion over to the plugin server, for organizations being part of the limited rollout of plugins on Cloud only (currently two: PostHog and Kea).
PLUGINS_CLOUD_WHITELISTED_ORG_IDS
will be removed in the next step of rollout, moving over ingestion for everyone.Needs new plugin server major version.