Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove emails from csv #3115

Merged
merged 5 commits into from
Jan 28, 2021
Merged

Remove emails from csv #3115

merged 5 commits into from
Jan 28, 2021

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Jan 28, 2021

Changes

Turns out the actual issue was that we were still doing a sequential scan on posthog_person to check if the input matched an ID. I think it's okay for now to just expect distinct ids, can add emails back in later.

Before, didn't finish within 30 seconds with 1000 distinct ids

After:
image

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@timgl timgl temporarily deployed to posthog-remove-emails-f-iqoksd January 28, 2021 10:27 Inactive
@timgl timgl temporarily deployed to posthog-remove-emails-f-iqoksd January 28, 2021 10:32 Inactive
@timgl timgl merged commit 108a502 into master Jan 28, 2021
@timgl timgl deleted the remove-emails-from-csv branch January 28, 2021 10:43
@timgl timgl mentioned this pull request Jan 28, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macobo macobo macobo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timgl @macobo