Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update demo data warning styles #3120

Merged
merged 2 commits into from
Jan 29, 2021
Merged

Update demo data warning styles #3120

merged 2 commits into from
Jan 29, 2021

Conversation

macobo
Copy link
Contributor

@macobo macobo commented Jan 28, 2021 •
edited
Loading

Left-over from #3103

2021-01-28_15-36

The star is aligned differently - not quite sure what it was supposed to be aligned with, looks ok to my eyes :)

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@timgl timgl temporarily deployed to posthog-update-alert-de-rldkvj January 28, 2021 13:39 Inactive
@timgl timgl temporarily deployed to posthog-update-alert-de-rldkvj January 29, 2021 08:10 Inactive
paolodamico
paolodamico approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@paolodamico paolodamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just did one final adjustment for when the new navigation is active.

@macobo macobo merged commit 9afc4a4 into master Jan 29, 2021
@macobo macobo deleted the update-alert-design branch January 29, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paolodamico paolodamico paolodamico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@macobo @paolodamico @timgl