Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make social login work with new Onboarding logic #3131

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Make social login work with new Onboarding logic #3131

merged 1 commit into from
Jan 29, 2021

Conversation

macobo
Copy link
Contributor

@macobo macobo commented Jan 29, 2021

After this, all organizations created go through a central Serializer containing relevant logic for adding an organization.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@timgl timgl temporarily deployed to posthog-onboarding-soci-b6uyl4 January 29, 2021 12:26 Inactive
paolodamico
paolodamico approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@paolodamico paolodamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@paolodamico paolodamico merged commit 0ed41c6 into master Jan 29, 2021
@paolodamico paolodamico deleted the onboarding-social-login branch January 29, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paolodamico paolodamico paolodamico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@macobo @paolodamico @timgl