Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify cohort queries #3165

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Simplify cohort queries #3165

merged 1 commit into from
Feb 2, 2021

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Feb 2, 2021

Changes

Previously each properties group would be wrapped in an entire scan of the person table. Change that to make all of those into just OR statements on the same person table scan.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@timgl timgl requested a review from EDsCODE February 2, 2021 17:45
@timgl timgl temporarily deployed to posthog-simplify-cohort-tgtuft February 2, 2021 17:49 Inactive
EDsCODE
EDsCODE approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@EDsCODE EDsCODE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@timgl timgl merged commit bd068e9 into master Feb 2, 2021
@timgl timgl deleted the simplify-cohort-queries branch February 2, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EDsCODE EDsCODE EDsCODE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timgl @EDsCODE