Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken url in paths #3168

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Fix broken url in paths #3168

merged 1 commit into from
Feb 2, 2021

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Feb 2, 2021

Changes

Please describe.

  • fixes this sentry error
  • we parse the domains to shorten the URLs, but if the url is broken for some reason when trying to use the URL class, just ignore it

If this affects the frontend, include screenshots.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

fuziontech
fuziontech approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@fuziontech fuziontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@timgl timgl temporarily deployed to posthog-broken-url-path-izlb3v February 2, 2021 18:18 Inactive
@EDsCODE EDsCODE merged commit 9cc9d40 into master Feb 2, 2021
@EDsCODE EDsCODE deleted the broken-url-path branch February 2, 2021 18:19
@EDsCODE EDsCODE mentioned this pull request Feb 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuziontech fuziontech fuziontech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EDsCODE @fuziontech @timgl