-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change graphs to ts #3181
Change graphs to ts #3181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice changes. Might cause minor merge conflicts but other than that LGTM.
@@ -137,7 +137,7 @@ export const trendsLogic = kea<trendsLogicType<FilterType, ActionType, TrendPeop | |||
|
|||
loaders: ({ values, props }) => ({ | |||
results: { | |||
__default: [], | |||
__default: [] as TrendResult[], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to pass TrendResult to kea as well - check the types file for if it has any errors.
Changes
Please describe.
If this affects the frontend, include screenshots.
Checklist