Alltime compare sentry error #3203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macobo
reviewed
Feb 4, 2021
| actions.setCompare(compare) | ||
| } | ||
| if (shown_as === ShownAsValue.LIFECYCLE || date_from === 'all') { |
There was a problem hiding this comment.
Wouldn't this make more sense as a selector rather than a separate action?
There was a problem hiding this comment.
Hmm can you pull searchparams in selector arguments? I've never done it before but if possible yeah we could move it there.
There was a problem hiding this comment.
Ah. Didn't realize it was search params - do we store them somewhere else (e.g. a related logic) - if so, connecting + selector might be cleaner.
This is nitpicking though, all else lgtm.
There was a problem hiding this comment.
connected to the router. I tried giving it a shot actually but it wasn't really making sense to me
macobo
approved these changes
Feb 4, 2021
|
Sentry issue: POSTHOG-23D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Please describe.
remove-shownasflag along with this sentry errorIf this affects the frontend, include screenshots.
Checklist