Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instrumentation Feb-8 #3238

Merged
merged 16 commits into from
Feb 9, 2021
Merged

Instrumentation Feb-8 #3238

merged 16 commits into from
Feb 9, 2021

Conversation

paolodamico
Copy link
Contributor

Changes

This PR introduces more instrumentation that will help improve our product.

  • Introduces event_usage.py module to do the same function as eventUsageLogic.ts in the BE. Related to that, abstracted some event usage reporting logic here.
  • Added more information on user $identify related to when the user's account was actually created and SSO usage.
  • Builds up on Release onboarding #2822 & final tweaks #3174 to introduce event tracking to several points of the new onboarding process.
  • Reports FE & BE events related to inviting team members.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@paolodamico paolodamico changed the base branch from master to onboarding-2822-release February 8, 2021 14:52
@timgl timgl temporarily deployed to posthog-instrumentation-9ghnzo February 8, 2021 14:55 Inactive
@paolodamico paolodamico marked this pull request as ready for review February 8, 2021 15:05
@timgl timgl temporarily deployed to posthog-instrumentation-9ghnzo February 8, 2021 15:05 Inactive
@timgl timgl temporarily deployed to posthog-instrumentation-9ghnzo February 8, 2021 15:19 Inactive
macobo
macobo reviewed Feb 9, 2021
View reviewed changes
Copy link
Contributor

@macobo macobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, but otherwise almost ready!

posthog/event_usage.py Show resolved Hide resolved
posthog/api/test/test_organization_invites.py Outdated Show resolved Hide resolved
posthog/api/organization_invite.py Outdated Show resolved Hide resolved
frontend/src/scenes/onboarding/personalizationLogic.ts Show resolved Hide resolved
frontend/src/lib/utils/eventUsageLogic.ts Outdated Show resolved Hide resolved
Base automatically changed from onboarding-2822-release to master February 9, 2021 13:28
@timgl timgl temporarily deployed to posthog-instrumentation-9ghnzo February 9, 2021 13:31 Inactive
@timgl timgl temporarily deployed to posthog-instrumentation-9ghnzo February 9, 2021 13:32 Inactive
@timgl timgl temporarily deployed to posthog-instrumentation-9ghnzo February 9, 2021 13:36 Inactive
@paolodamico
Copy link
Contributor Author

Thanks for the review @macobo 💥 ! Feedback addressed and PR rebased. Will merge after tests pass.

For future reference, cloud tests will fail because we introduced more attributes to the signup (which is overriden on posthog-production). Will fix the tests in posthog-production post-merge.

@timgl timgl temporarily deployed to posthog-instrumentation-9ghnzo February 9, 2021 13:51 Inactive
@paolodamico paolodamico merged commit 3c46b93 into master Feb 9, 2021
@paolodamico paolodamico deleted the instrumentation-feb8 branch February 9, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macobo macobo macobo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paolodamico @macobo @timgl