Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make page not jumpy on initial load #3246

Merged
merged 1 commit into from
Feb 10, 2021
Merged

Make page not jumpy on initial load #3246

merged 1 commit into from
Feb 10, 2021

Conversation

macobo
Copy link
Contributor

@macobo macobo commented Feb 8, 2021

By showing side nav even if scene has not loaded.

This fixes #3020

Before/after: https://imgur.com/a/k1zo7DG on a 3G connection

Posthog logo loads instantly on 2nd page load in production - caching rule set up in cloudflare

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@timgl timgl temporarily deployed to posthog-load-jumpy-fix-ccubevx February 8, 2021 20:13 Inactive
Copy link
Collaborator

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflict needs resolving, but this looks good

By showing side nav even if scene has not loaded.

This fixes #3020
@macobo macobo temporarily deployed to posthog-load-jumpy-fix-ccubevx February 10, 2021 06:28 Inactive
@macobo macobo merged commit 3311b0d into master Feb 10, 2021
@macobo macobo deleted the load-jumpy-fix branch February 10, 2021 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page is jumpy on first load (new nav)
3 participants