Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve entity rows layout #3255

Merged
merged 3 commits into from
Feb 9, 2021
Merged

Improve entity rows layout #3255

merged 3 commits into from
Feb 9, 2021

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Feb 9, 2021

Changes

The previous close button was way too subtle and in the wrong place (it was under filters?). This is much clearer

image

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@timgl timgl temporarily deployed to posthog-improve-entity--6vhacy February 9, 2021 10:32 Inactive
Copy link
Contributor

@paolodamico paolodamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found an edge case, let me fix this first.

@timgl timgl temporarily deployed to posthog-improve-entity--6vhacy February 9, 2021 11:58 Inactive
@timgl timgl temporarily deployed to posthog-improve-entity--6vhacy February 9, 2021 12:01 Inactive
@paolodamico
Copy link
Contributor

Well this took a bit longer than expected, stubborn divs... & a hacky CSS solution, but see below,

We should make a note that the experience isn't great for certain screen widths (see example below) where the screen is small but not too small to trigger the mobile breakpoint. From a user standpoint it'd be great to have a different multi-line layout, but we need to be deliberate about the design so each group set is clear.

@timgl timgl merged commit 50ae632 into master Feb 9, 2021
@timgl timgl deleted the improve-entity-rows-layout branch February 9, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants