Fix emails not shown on user id #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good on Events but not on live actions - unless I misunderstand the expected behaviour the user should be the email I've used not the instance? |
|
Good catch, will fix. |
timgl
force-pushed
the
fix-emails-not-shown-on-user-id
branch
from
89d9b45
to
ef3066b
Compare
timgl
force-pushed
the
fix-emails-not-shown-on-user-id
branch
from
ef3066b
to
de6a72f
Compare
timgl
force-pushed
the
fix-emails-not-shown-on-user-id
branch
from
de6a72f
to
e163746
Compare
yakkomajuri
added a commit
that referenced
this pull request
Oct 1, 2021
* Add for user props * minor fix * clone object so properties still exist * better approach * convert to sql * handle increment update to string values * simplify query * add test, filter props * move to bigint, check for overflows * update tests * fix test * fixes * remove lingering comment * handle negative ints Co-authored-by: Marius Andra <marius.andra@gmail.com> Co-authored-by: Michael Matloka <dev@twixes.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Tannergoods See https://github.com/PostHog/posthog/wiki/How-to-QA on how to add user properties for QA !
I touched the logic for how we display lists of events so worth checking a couple of places (like /actions, /actions/live, /events etc)