Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mutating process_event_ee bug #3263

Merged
merged 1 commit into from Feb 9, 2021
Merged

Fix mutating process_event_ee bug #3263

merged 1 commit into from Feb 9, 2021

Conversation

mariusandra
Copy link
Collaborator

Changes

  • The function process_event_ee mutates the event by removing $elements from properties.
  • This PR changes the order of process_event_ee and log_event, so that both get the pure event.
  • This applies only to a situation when running 1) ee + kafka, 2) still using python ingestion and not the NodeJS ingestion 3) using plugins via the WAL (no ingestion)

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@timgl timgl temporarily deployed to posthog-fix-pluginless--c27xab February 9, 2021 13:32 Inactive
@Twixes Twixes merged commit a19978a into master Feb 9, 2021
@Twixes Twixes deleted the fix-pluginless-ingestion-wal branch February 9, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Twixes Twixes Awaiting requested review from Twixes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mariusandra @timgl @Twixes