Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc plugin improvements #3288

Merged
merged 17 commits into from
Feb 11, 2021
Merged

Misc plugin improvements #3288

merged 17 commits into from
Feb 11, 2021

Conversation

mariusandra
Copy link
Collaborator

Changes

  • Sort the repository alphabetically
  • Open the "repository" tab if no plugins are installed (and we have access to it)
  • Fix issue where the same plugin can't be installed in different organisations (plugins are scoped to organisation)
  • Test for the latter [WIP]

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@timgl timgl temporarily deployed to posthog-plugin-access-yofccdql February 10, 2021 10:52 Inactive
@mariusandra mariusandra temporarily deployed to posthog-plugin-access-yofccdql February 10, 2021 11:10 Inactive
@Twixes Twixes temporarily deployed to posthog-plugin-access-yofccdql February 10, 2021 11:59 Inactive
@mariusandra mariusandra temporarily deployed to posthog-plugin-access-yofccdql February 10, 2021 21:00 Inactive
@mariusandra mariusandra temporarily deployed to posthog-plugin-access-yofccdql February 10, 2021 21:05 Inactive
@mariusandra mariusandra marked this pull request as ready for review February 10, 2021 23:05
@mariusandra
Copy link
Collaborator Author

A bunch of fixes and simplifications that can be looked at and merged. Probably more still to come, but then in other PRs.

Aside: once things quiet down, we needs tests on the frontend here!

@Twixes Twixes temporarily deployed to posthog-plugin-access-yofccdql February 11, 2021 10:06 Inactive
@Twixes Twixes merged commit fd57536 into master Feb 11, 2021
@Twixes Twixes deleted the plugin-access branch February 11, 2021 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants