Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix breaking down by "all" cohorts when no other cohorts #3374

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Fix breaking down by "all" cohorts when no other cohorts #3374

merged 1 commit into from
Feb 19, 2021

Conversation

macobo
Copy link
Contributor

@macobo macobo commented Feb 18, 2021

Fixes https://sentry.io/organizations/posthog/issues/2213824556/?project=1899813&query=is%3Aunassigned+is%3Aunresolved

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@macobo macobo requested a review from EDsCODE February 18, 2021 09:11
@sentry-io
Copy link

sentry-io bot commented Feb 18, 2021

Sentry issue: POSTHOG-2AQ

@timgl timgl temporarily deployed to posthog-fix-trends-brea-v1yiwv February 18, 2021 09:14 Inactive
EDsCODE
EDsCODE approved these changes Feb 19, 2021
View reviewed changes
Copy link
Member

@EDsCODE EDsCODE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@macobo macobo merged commit 279ab4d into master Feb 19, 2021
@macobo macobo deleted the fix-trends-breakdown-by-all-with-no-cohorts branch February 19, 2021 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EDsCODE EDsCODE EDsCODE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@macobo @EDsCODE @timgl