Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reordering funnel steps #3412

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Conversation

macobo
Copy link
Contributor

@macobo macobo commented Feb 19, 2021

You can now drag the whole "row" not just by the handle

distance now needs to be set not to interact badly with dropdown menus -
by default it would eat all the clicks.

Fixes #3410

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

You can now drag the whole "row" not just by the handle

distance now needs to be set not to interact badly with dropdown menus -
by default it would eat all the clicks.

Fixes #3410
@macobo macobo requested a review from EDsCODE February 19, 2021 16:15
@timgl timgl temporarily deployed to posthog-improve-reorder-ire8ta February 19, 2021 16:18 Inactive
Copy link
Member

@EDsCODE EDsCODE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@EDsCODE EDsCODE merged commit e50980c into master Feb 19, 2021
@EDsCODE EDsCODE deleted the improve-reordering-funnel-steps branch February 19, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve UX of reordering funnel steps
3 participants