Don't null IPs for teams who toggled an ancient field #3462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
It's normally not good practice to change old migrations, but since we're working with releases and this hasn't gone out yet, might as well.
I think this line is wrong (passed my review, sorry).
team.anonymize_ips
means we just don't store IP information with events.team.opt_out_capture
was an old flag to disable tracking on self-hosted instances. They don't mean the same thing.The impact is probably zero users so far, but if we release with this line, then after upgrading to 1.22, some really old and still running installations that had flipped this switch will suddenly stop seeing IP addresses with their event properties. Best to revert I think.
Checklist