Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable unnecessary chart filters on retention #3521

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Disable unnecessary chart filters on retention #3521

merged 1 commit into from
Mar 3, 2021

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Mar 1, 2021 •
edited
Loading

Changes

Please describe.

  • there were several chart filter options enabled that didn't do anything
    If this affects the frontend, include screenshots.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@timgl timgl temporarily deployed to posthog-disable-chart-f-jmh2sk March 1, 2021 16:04 Inactive
@Twixes Twixes requested a review from timgl March 1, 2021 20:57
@yakkomajuri yakkomajuri merged commit 55a2980 into master Mar 3, 2021
@yakkomajuri yakkomajuri deleted the disable-chart-filters-on-retention branch March 3, 2021 10:21
yakkomajuri pushed a commit that referenced this pull request Mar 3, 2021
@EDsCODE @yakkomajuri
disable unnecessary chart filters on retention (#3521)
c27efb1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yakkomajuri yakkomajuri yakkomajuri approved these changes

@timgl timgl Awaiting requested review from timgl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EDsCODE @yakkomajuri @timgl