-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show toast on API errors #3561
Show toast on API errors #3561
Conversation
@mariusandra if you don't mind I'll hijack your PR, make some tweaks and get this out, want to get this in before the code freeze. |
Please! |
Ready for a review @mariusandra! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and considering I was already happy with how these toasts were before they were removed, I can only approve!
Because of this bias I'd say @timgl should also say if the approach works for him.
It's good that we can easily add actions to be ignored. This will help keep the interface noise free.
There's just one UX issue that I think should be solved, best illustrated by a screencast:
If we show only one error, then I'd always like to see the last error shown to me, as that's probably the most urgent one.
Agreed @mariusandra, I've updated it so that the last error is the one that's actually shown. Will wait for @timgl's input on the UX before merging. |
(PR hijacked by @paolodamico , ignore @mariusandra 's face next to the text)
Changes
Closes #3525. This PR brings back toast errors when something goes wrong, with a few key differences.
Examples:
![](https://user-images.githubusercontent.com/5864173/112386663-77615e00-8cae-11eb-9864-7d5f7030350f.png)
![](https://user-images.githubusercontent.com/5864173/112386669-7af4e500-8cae-11eb-9fc6-6168a17e319a.png)
![](https://user-images.githubusercontent.com/5864173/112386683-80522f80-8cae-11eb-92d2-5d3dce0b4cc5.png)
All feedback welcome!
Checklist