Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event property calculation bugfix #3579

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Event property calculation bugfix #3579

merged 1 commit into from
Mar 4, 2021

Conversation

mariusandra
Copy link
Collaborator

@mariusandra mariusandra commented Mar 4, 2021 •
edited
Loading

Changes

  • On cloud this prop was also "utm_medium__icontains" and "current_url__icontains" instead of a dict. Not sure why (old broken dashboard items?), but safe to ignore I think.
  • Fixes this sentry error

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@mariusandra mariusandra requested a review from timgl March 4, 2021 13:55
@timgl timgl temporarily deployed to posthog-event-property--hmnpli March 4, 2021 13:57 Inactive
@mariusandra mariusandra mentioned this pull request Mar 4, 2021
Closed
4 tasks
@mariusandra mariusandra merged commit 2477ce9 into master Mar 4, 2021
@mariusandra mariusandra deleted the event-property-bugfix branch March 4, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timgl timgl timgl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mariusandra @timgl