Improve formulas UI/input #3620
Conversation
There was a problem hiding this comment.
lgtm! suggesting some UI adjustments. While I do think this is a great improvement, I think the UX of this is still a bit wanting (for a separate PR). I was thinking that maybe we could autocomplete the input and instead of the user typing "A", they would select the element, and we would add more info on each element, something along these lines.
| // Only allow typing of allowed characters | ||
| value = value | ||
| .split('') | ||
| .filter((d) => /^[a-zA-Z\ \-\*\^0-9\+\/\(\)]+$/g.test(d)) |
There was a problem hiding this comment.
You could even restrict to allow adding only letters for the number of graphs currently being showed.
|
Pushed commit adjusts the styling a bit, And fixes this jumpiness,
|
|
Let me know if you want me to take another look |
|
@paolodamico I've merged, I checked your changes and they looked good. Worth checking quickly on master, then we can probably start releasing to 10-20% of users? |
|
We were a bit stuck on deploys today but all good now. Tested on production and seems to work just fine. Releasing right now to 15% of all real users. Maybe worth opening an issue on the experiments repo to document the experiment? |
Changes
Only allow certain characters to be entered, add letters next to the graph series
Checklist