Default event property usage to false #3655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpthatsme
approved these changes
Mar 15, 2021
| type="warning" | ||
| message={ | ||
| <> | ||
| Event usage is not enabled on your instance. If you want to enable event usage please set the follow |
There was a problem hiding this comment.
Should we say Event Property usage is not enabled? Or does this setting disable events as well
There was a problem hiding this comment.
Yeah it should change depending on which tab you're on
kpthatsme
approved these changes
Mar 15, 2021
yakkomajuri
pushed a commit
that referenced
this pull request
Mar 18, 2021
* Default event property usage to false * fix type errors and wording
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Given this was completely broken before and given #3642 I think it's fine to release this as False by default. If you go to the page and the env var is set to false we will display a message.
This also increases the interval from once a minute to once an hour. It definitely should not have been once a minute, and this change alone may have helped the user at #3642. Regardless I think it's better to try and reduce the load by defaulting to false.
Checklist