Speed up filtering by events in sessions #3707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macobo
force-pushed
the
session-filtering-speedup
branch
from
f295c48
to
74b8a85
Compare
For very rare events, filtering by them in sessions previously was slow. This was because the the distinct_id query contained a lot of users who hadn't done the action, resulting in more looping. This commit speeds things up by querying users who have done any events matching the event/action filter.
macobo
force-pushed
the
session-filtering-speedup
branch
from
74b8a85
to
9fc5a4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
restructure the code
Clean up complicated function using namedtuple
Speed up action/event filtering in clickhouse
For very rare events, filtering by them in sessions previously was slow.
This was because the the distinct_id query contained a lot of users who
hadn't done the action, resulting in more looping.
This commit speeds things up by querying users who have done any events matching the
event/action filter.
No benchmarks (sorry) since I did not have access to clickhouse outside of metabase.
Checklist