Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unmounted logic bug on shared dashboards #3712

Merged
merged 2 commits into from
Mar 23, 2021
Merged

Fix unmounted logic bug on shared dashboards #3712

merged 2 commits into from
Mar 23, 2021

Conversation

paolodamico
Copy link
Contributor

Changes

Fixes this bug https://sentry.io/organizations/posthog/issues/2275276580/ in which userLogic was accessed while unmounted. Happened when viewing a shared dashboard which is viewed anonymously.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@timgl timgl temporarily deployed to posthog-fix-event-usage-5eipio March 21, 2021 18:54 Inactive
@timgl timgl temporarily deployed to posthog-fix-event-usage-5eipio March 23, 2021 20:04 Inactive
@paolodamico paolodamico merged commit 8a35701 into master Mar 23, 2021
@paolodamico paolodamico deleted the fix-event-usage-logic branch March 23, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusandra mariusandra mariusandra left review comments

@Twixes Twixes Twixes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@paolodamico @mariusandra @Twixes @timgl