Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for non-plugin config-keyed plugin attachments #3732

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Allow for non-plugin config-keyed plugin attachments #3732

merged 1 commit into from
Mar 23, 2021

Conversation

Twixes
Copy link
Collaborator

@Twixes Twixes commented Mar 23, 2021

Changes

Small DB schema change allowing for a PostHog/plugin-server#247 optimization.

@Twixes Twixes requested a review from mariusandra March 23, 2021 17:14
@timgl timgl temporarily deployed to posthog-global-plugin-a-atd7n7 March 23, 2021 17:26 Inactive
@mariusandra
Copy link
Collaborator

I assume key will be something unique for global attachments?

@Twixes
Copy link
Collaborator Author

Twixes commented Mar 23, 2021

I guess it can be prefixed with something like @plugin-server/?

@mariusandra mariusandra merged commit ac5fa06 into master Mar 23, 2021
@mariusandra mariusandra deleted the global-plugin-attachments branch March 23, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusandra mariusandra mariusandra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Twixes @mariusandra @timgl