Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show legend if nothing to show #3763

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Don't show legend if nothing to show #3763

merged 1 commit into from
Mar 30, 2021

Conversation

macobo
Copy link
Contributor

@macobo macobo commented Mar 26, 2021 •
edited
Loading

Changes

It shows an empty table right now, which is ugly.

image

This is when you skip the old onboarding

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@macobo macobo requested a review from EDsCODE March 26, 2021 08:17
@timgl timgl temporarily deployed to posthog-pr-3763 March 26, 2021 08:26 Inactive
EDsCODE
EDsCODE approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@EDsCODE EDsCODE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@EDsCODE EDsCODE merged commit 98a1c73 into master Mar 30, 2021
@EDsCODE EDsCODE deleted the no-legend-if-empty branch March 30, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EDsCODE EDsCODE EDsCODE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@macobo @EDsCODE @timgl