Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure the proper math is applied when calculating top elements for breakdown #3771

Merged
merged 1 commit into from Mar 26, 2021
Merged

Make sure the proper math is applied when calculating top elements for breakdown #3771

merged 1 commit into from Mar 26, 2021

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Mar 26, 2021 •
edited

Changes

Please describe.

  • the clickhouse implementation of breakdowns runs a query to get top elements that will be queried in the breakdown query but the query previously was not accounting for math_funs
  • implements math into the query and adds tests
  • fixes this issue
    If this affects the frontend, include screenshots.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@EDsCODE EDsCODE requested a review from kpthatsme March 26, 2021 20:28
@timgl timgl temporarily deployed to posthog-pr-3771 March 26, 2021 20:38 Inactive
kpthatsme
kpthatsme approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@kpthatsme kpthatsme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to test the exact figures with demo data but played around with charts and such. Will give it a closer look in prod, lgtm!

@kpthatsme kpthatsme merged commit 1176913 into master Mar 26, 2021
@kpthatsme kpthatsme deleted the ops-217-breakdown-issue branch March 26, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpthatsme kpthatsme kpthatsme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EDsCODE @kpthatsme @timgl