Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning to breakdown that we only show top 20 values #3779

Merged
merged 2 commits into from
Mar 29, 2021

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Mar 29, 2021

Changes

People get confused about this sometimes. I know we have something in the works to be able to show more but this is helpful for now.

image

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@timgl timgl requested a review from EDsCODE March 29, 2021 10:26
@timgl timgl temporarily deployed to posthog-pr-3779 March 29, 2021 10:32 Inactive
@timgl timgl temporarily deployed to posthog-pr-3779 March 29, 2021 12:58 Inactive
Copy link
Contributor

@paolodamico paolodamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! agreed that the best option is to support more than 20, but great for now. Made a counter proposal, feel free to change/discard it.

@timgl timgl merged commit 9cbc709 into master Mar 29, 2021
@timgl timgl deleted the add-breakdown-top-20-warning branch March 29, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants