Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change created_at to _timestamp #3820

Merged
merged 2 commits into from
Mar 30, 2021
Merged

change created_at to _timestamp #3820

merged 2 commits into from
Mar 30, 2021

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Mar 30, 2021 •
edited
Loading

Changes

Please describe.

  • currently using created_at to find latest person row but duplicates are requiring _timestamp to properly filter them out
  • removing test because it's testing irrelevant version of code (relying on created_at when you really need _timestamp)

If this affects the frontend, include screenshots.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@timgl timgl temporarily deployed to posthog-pr-3820 March 30, 2021 20:06 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-pr-3820 March 30, 2021 21:18 Inactive
@EDsCODE EDsCODE merged commit 1768b89 into master Mar 30, 2021
@EDsCODE EDsCODE deleted the use-_timestamp branch March 30, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EDsCODE @timgl