Swap out person_distinct_id in queries with subquery #3828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…consider latest distinct_ids
|
I did some manual testing across the analytics and the one that I had to skip for significant degraded performance was the lifecycle query |
EDsCODE
commented
Mar 31, 2021
| @@ -65,6 +65,13 @@ | |||
| {query} | |||
| """ | |||
|
|
|||
| GET_LATEST_PERSON_DISTINCT_ID_SQL = """ | |||
| SELECT * FROM person_distinct_id JOIN ( | |||
| SELECT distinct_id, max(_offset) as _offset FROM person_distinct_id WHERE team_id = %(team_id)s GROUP BY distinct_id | |||
There was a problem hiding this comment.
I'm using offset because it has more precision than _timestamp since _timestamp doesn't consider seconds
fuziontech
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Please describe.
person_distinct_iduse a subquery to ensure the distinct_ids in consideration are always the latestIf this affects the frontend, include screenshots.
Checklist