Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cypress dependencies #3881

Merged
merged 9 commits into from Apr 6, 2021
Merged

Fix cypress dependencies #3881

merged 9 commits into from Apr 6, 2021

Conversation

paolodamico
Copy link
Contributor

@paolodamico paolodamico commented Apr 6, 2021

Changes

UPDATE: The broken dependency issue seems to have been fixed upstream. This PR still might be worth so we don't have unnecessary devDependencies installed.

  • This PR also fixes a broken test and improves the output of formatLabel() utility.

Today all frontend-related CI runs started failing (could be due to this, cypress-io/cypress#15797).

  • This PR removes @cypress dependencies from main package.json in favor of installing them directly in the CI runs (as we do with the main cypress package).
  • We also target a specific version of these dependencies that works fine.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User. Not applicable.
  • Django backend tests. Not applicable.
  • Jest frontend tests
  • Cypress end-to-end tests

@timgl timgl temporarily deployed to posthog-pr-3881 April 6, 2021 04:43 Inactive
@paolodamico paolodamico marked this pull request as draft April 6, 2021 04:46
@paolodamico paolodamico marked this pull request as ready for review April 6, 2021 13:19
@timgl timgl temporarily deployed to posthog-pr-3881 April 6, 2021 13:19 Inactive
@timgl timgl temporarily deployed to posthog-pr-3881 April 6, 2021 13:48 Inactive
@timgl timgl temporarily deployed to posthog-pr-3881 April 6, 2021 13:59 Inactive
@timgl timgl temporarily deployed to posthog-pr-3881 April 6, 2021 14:10 Inactive
@timgl timgl temporarily deployed to posthog-pr-3881 April 6, 2021 14:17 Inactive
@timgl timgl temporarily deployed to posthog-pr-3881 April 6, 2021 15:40 Inactive
Copy link
Member

@EDsCODE EDsCODE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now. There seems to be a flaky backend test though

package.json Show resolved Hide resolved
@paolodamico
Copy link
Contributor Author

Failing backend test is unrelated. Merging https://github.com/PostHog/posthog-cloud/pull/100/ will fix it.

@paolodamico paolodamico merged commit 262e284 into master Apr 6, 2021
@paolodamico paolodamico deleted the fix-cypress-dependencies branch April 6, 2021 16:21
@EDsCODE
Copy link
Member

EDsCODE commented Apr 6, 2021

Hmm I just realized though that we're going to need some solution for running cypress locally

@paolodamico
Copy link
Contributor Author

Well I can whip up a simple script. Usually what I do is just copy the command on the GH script and run it.

@EDsCODE EDsCODE mentioned this pull request Apr 8, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants