Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shared dashboard rendering with multiline descriptions #3885

Merged
merged 1 commit into from Apr 6, 2021
Merged

Fix shared dashboard rendering with multiline descriptions #3885

merged 1 commit into from Apr 6, 2021

Conversation

paolodamico
Copy link
Contributor

Changes

Dashboards which had multi-line descriptions were not rendering properly when shared.

Reported by a user

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@paolodamico paolodamico requested a review from EDsCODE April 6, 2021 17:10
@timgl timgl temporarily deployed to posthog-pr-3885 April 6, 2021 17:15 Inactive
@sentry-io
Copy link

sentry-io bot commented Apr 6, 2021

Sentry issue: POSTHOG-2KD

@paolodamico paolodamico merged commit d44138c into master Apr 6, 2021
@paolodamico paolodamico deleted the fix-shared-dashboard-with-multine-description branch April 6, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EDsCODE EDsCODE Awaiting requested review from EDsCODE

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paolodamico @timgl