Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix property popover arrow placement on cohorts page #3893

Merged
merged 1 commit into from Apr 8, 2021
Merged

Fix property popover arrow placement on cohorts page #3893

merged 1 commit into from Apr 8, 2021

Conversation

adrienbrault
Copy link
Contributor

Changes

Before:

Screen Shot 2021-04-07 at 13 53 04

After:

Screen Shot 2021-04-07 at 13 53 57

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

paolodamico
paolodamico approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@paolodamico paolodamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff, thanks @adrienbrault !

@paolodamico paolodamico merged commit fa40811 into PostHog:master Apr 8, 2021
@adrienbrault adrienbrault deleted the popover-cohort-property branch April 9, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paolodamico paolodamico paolodamico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adrienbrault @paolodamico