Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes project settings not loading #3950

Merged
merged 2 commits into from Apr 12, 2021
Merged

Fixes project settings not loading #3950

merged 2 commits into from Apr 12, 2021

Conversation

paolodamico
Copy link
Contributor

Changes

Fixes two bugs discovered in the Break the release session.

  • Webhook will not get loaded after a refresh if the first page being loaded is the /project/settings page.
  • Same for test account filters.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious

@timgl timgl requested a deployment to posthog-pr-3950 April 12, 2021 15:24 Abandoned
@paolodamico paolodamico mentioned this pull request Apr 12, 2021
Closed
samwinslow
samwinslow approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@samwinslow samwinslow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works. Glad this was an easy fix!

@timgl timgl temporarily deployed to posthog-pr-3950 April 12, 2021 15:26 Inactive
@paolodamico paolodamico enabled auto-merge (squash) April 12, 2021 15:26
@paolodamico paolodamico merged commit 328f483 into master Apr 12, 2021
@paolodamico paolodamico deleted the fix-project-settings-v24 branch April 12, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samwinslow samwinslow samwinslow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paolodamico @samwinslow @timgl